-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTP recovery and verification strategy #2184
OTP recovery and verification strategy #2184
Conversation
@aeneasr will add a small guide about how to configure Kratos with Twilio and use phone numbers as identifiers, plus recovery and verification process |
@splaunov just for your information - this PR implements recovery and verification by using OTP codes. Maybe you will find it useful |
1c7fba1
to
6c7aca0
Compare
@alexey-reshetnik could you give a brief flow chart of how you except the flow to work? You can use mermaid to create such a chart :) I think we have a couple of states we need to take care of:
and probably a few other error flows :) Also, it would be awesome if the OTP strategy could work with links as well, so for example:
which would pre-fill the form with the OTP code. This could be useful if we want to use this strategy to send magic links and would basically render the link strategy completely obsolete. Also, we need to talk about entropy. Either, we make the OTP entropy high enough (e.g. WDYT? |
Hi! But after the review it seems to me that there is a good reason to merge it with the 'code' registration/login strategy. What do you think? |
fyi I am currently working on passwordless auth using webauthn. I suggest that once it is merged we copy that pattern for SMS auth: #2260 |
6c7aca0
to
0018efe
Compare
0018efe
to
d938b8c
Compare
2e1a07c
to
d5fe68e
Compare
f6838e2
to
2cb7536
Compare
Codecov Report
@@ Coverage Diff @@
## master #2184 +/- ##
==========================================
- Coverage 75.26% 73.10% -2.16%
==========================================
Files 294 299 +5
Lines 17159 16935 -224
==========================================
- Hits 12914 12380 -534
- Misses 3266 3613 +347
+ Partials 979 942 -37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8df90be
to
64485cd
Compare
64485cd
to
45ddf6f
Compare
0a50a8c
to
5f6d1cb
Compare
Changes:
otp
strategy (similar to link) with recovery and verification methods implementationRelated issue(s)
Needs #1941 to be merged
Implements #1451
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments